Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing Assets #4

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Existing Assets #4

merged 6 commits into from
Oct 14, 2024

Conversation

Spartwo
Copy link
Collaborator

@Spartwo Spartwo commented Oct 14, 2024

Various Restock TURD assets and configs I've made over time

@Spartwo
Copy link
Collaborator Author

Spartwo commented Oct 14, 2024

  • DTS-M1 Antenna
  • Transform names for Truss, IBeam, and Node Parts
  • Non-DLC Panels
  • Structural Trusses and Nodes
  • Rapier
  • Material bay
  • Resizable Structural Tubes

Tubes were in making history so I missed them
@likeproblem
Copy link
Owner

Hello, there's a problem with configs. For some reason Default one have the same configs as Recolour one, which shouldn't happen

For example, Default should have MODULE{name = KSPTextureSwitch...} instead of MODULE[KSPTextureSwitch]{...}

@Spartwo
Copy link
Collaborator Author

Spartwo commented Oct 14, 2024

Bit of an oversight. Will fix

Given a few days I'll update this to have full tested sets. Wished to avoid work overlap in the immediate term

@likeproblem
Copy link
Owner

likeproblem commented Oct 14, 2024

Hey, is it okay with you if I only pull textures and make configs from (almost) ground up? It is better to create it from scratch then try to fix it

@Spartwo
Copy link
Collaborator Author

Spartwo commented Oct 14, 2024

Hey, is it okay with you if I only pull textures and make configs from (almost) ground up? It is better to create it from scratch then try to fix it

No

I'm just finished making configs. I wrote an earlier message that I've done this so there's no risk of file and work conflicts.

Please do not create one

@Spartwo
Copy link
Collaborator Author

Spartwo commented Oct 14, 2024

image

@UncleMateo
Copy link
Collaborator

Awesome work!

@UncleMateo
Copy link
Collaborator

Hey Spartwo, double check your Paint/Recolor configs, I noticed a handful of parts with the 000 precursor, but for the Paint you need that part to start with 999 or it won't load in the right order. Didn't see any other issues on a quick skim.

@UncleMateo
Copy link
Collaborator

uh I guess the underscore does italics on this board
oops
Well you probably get the idea without them

Beams, Nodes, Trusses, Tubes, and Plates

Plus:
- Oscar B fuel tank
- Foil Antenna
- Science Jr
- Rapier
@Spartwo
Copy link
Collaborator Author

Spartwo commented Oct 14, 2024

Hey Spartwo, double check your Paint/Recolor configs, I noticed a handful of parts with the 000 precursor, but for the Paint you need that part to start with 999 or it won't load in the right order. Didn't see any other issues on a quick skim.

Way ahead of you

@likeproblem
Copy link
Owner

Looks great and should be ready to merge! Thanks again for contribution, though some stuff is named differently, but I leave it as is.

@UncleMateo do we want to edit anything else or we merge now?

@UncleMateo
Copy link
Collaborator

Looks good to me.. Just in case, I made a local backup of the previous build.

@UncleMateo UncleMateo merged commit 8239c9e into likeproblem:main Oct 14, 2024
@likeproblem
Copy link
Owner

I'll probably remove @name = ... additions, they can be implemented into TextureSets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants