Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limactl: deprecate limactl show-ssh (Use ssh -F ... instead) #1811

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

AkihiroSuda
Copy link
Member

limactl show-ssh is now deprecated.
Instead, use ssh -F ~/.lima/default/ssh.config lima-default .

@AkihiroSuda AkihiroSuda added impact/changelog area/cli limactl CLI user experience labels Sep 19, 2023
@AkihiroSuda AkihiroSuda added this to the v0.18.0 milestone Sep 19, 2023
@AkihiroSuda
Copy link
Member Author

cc @jandubois @abiosoft @pendo324 FYI

@afbjorklund
Copy link
Member

So you should use cat ~/.lima/default/ssh.config, if you need the config for some other program ?

@AkihiroSuda
Copy link
Member Author

So you should use cat ~/.lima/default/ssh.config, if you need the config for some other program ?

Yes.

`limactl show-ssh` is now deprecated.
Instead, use `ssh -F ~/.lima/default/ssh.config lima-default` .

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@afbjorklund
Copy link
Member

I sort of liked the old command, and think this is something of a regression...

With docker-machine and podman machine, the ssh was always hidden from the user.

The Lima approach made it simple to get the config in various formats, and set up ssh.

Now we are back to knowing location of files, and so on. Just my initial thoughts.

@AkihiroSuda
Copy link
Member Author

Now we are back to knowing location of files, and so on.

limactl ls --format='{{.SSHConfigFile}}' can be still used

@jandubois
Copy link
Member

cc @jandubois @abiosoft @pendo324 FYI

Fine with me (see also #338 (comment)) 😄

@afbjorklund
Copy link
Member

Yeah well that just leads back to the inspect discussion so I think I will just abstain from "voting".

But adding the lima hosts to ~/.ssh/config was still a neat thing, no matter how it is accomplished.

Then you could ssh or rsync or what have you, using only the lima-default.

I thought that was a pretty neat party trick. For most other things, there's lima.

@AkihiroSuda
Copy link
Member Author

But adding the lima hosts to ~/.ssh/config was still a neat thing, no matter how it is accomplished.

limactl show-ssh doesn't do this automatically.

You can add Include ~/.lima/default/ssh.config in ~/.ssh/config manually though.

@AkihiroSuda
Copy link
Member Author

Can we merge?

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@AkihiroSuda AkihiroSuda merged commit 6046136 into lima-vm:master Sep 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli limactl CLI user experience impact/changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants