Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/networks: refactor dnshosts.ExtractZones #2355

Merged
merged 1 commit into from
May 22, 2024
Merged

pkg/networks: refactor dnshosts.ExtractZones #2355

merged 1 commit into from
May 22, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented May 22, 2024 •
edited
Loading

The PR refactors dnshosts.ExtractZones by preallocating the resulting zones slice due to the known length.

@alexandear
pkg/networks: refactor dnshosts.ExtractZones
2803a3c 
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
jandubois
jandubois approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 558da94 into lima-vm:master May 22, 2024
27 checks passed
@jandubois jandubois added this to the v0.23.0 (tentative) milestone May 22, 2024
@alexandear alexandear deleted the dnshosts-improve-extract-zones branch May 22, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @jandubois