Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental notice for vz, 9p, user-v2 net, grpc forwarder #2758

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Remove experimental notice for vz, 9p, user-v2 net, grpc forwarder #2758

merged 1 commit into from
Oct 17, 2024
+20 −36

Conversation

AkihiroSuda
Copy link
Member

No description provided.

@AkihiroSuda AkihiroSuda added the documentation Improvements or additions to documentation label Oct 17, 2024
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Oct 17, 2024
jandubois
jandubois requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we need to keep the hint that virtiofs requires vz.

examples/default.yaml Outdated Show resolved Hide resolved
examples/default.yaml Outdated Show resolved Hide resolved
website/content/en/docs/config/mount/_index.md Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda force-pushed the clean-up-experimental branch 2 times, most recently from 0de3f52 to fa6fb56 Compare October 17, 2024 17:23
jandubois
jandubois previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

examples/default.yaml Outdated Show resolved Hide resolved
@AkihiroSuda
Remove experimental notice for vz, 9p, user-v2 net, grpc forwarder
d138966 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
jandubois
jandubois approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit b33c40b into lima-vm:master Oct 17, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AkihiroSuda @jandubois