-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: create separate artifacts for macos-{13,14,15} #2762
base: master
Are you sure you want to change the base?
Conversation
f54eb3b
to
78c63ef
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Now the following artifacts are created: - lima-VERSION-Darwin_macOS13-{arm64,x86_64}.tar.gz - lima-VERSION-Darwin_macOS14-{arm64,x86_64}.tar.gz - lima-VERSION-Darwin_macOS15-{arm64,x86_64}.tar.gz - lima-VERSION-Darwin-{arm64,x86_64}.tar.gz (identical to `*-Darwin_macOS15-*`) - lima-VERSION-Linux-{aarch64,x86_64}.tar.gz Fix issue 2753 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Don't really like mixing
|
I considered this, but I don't like splitting the OS identifier to two and put the arch name between them |
Alternatively we can have
But this will probably break somebody's script |
I know, but it is the only way to keep all the releases for each arch together. |
Anyways, looks like every possible naming scheme has some drawbacks, so we just have to pick one. If you prefer the one with the |
We already have an underscore in "x86_64", so I think this is fine? |
Now the following artifacts are created:
*-Darwin_macOS15-*
)Fix #2753