Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title: Fix Bugs, Enhance Compatibility, and Improve Defaults in Pull Request #5

Merged
merged 11 commits into from
Nov 12, 2023

Conversation

jayxuz
Copy link
Contributor

@jayxuz jayxuz commented Oct 23, 2023

This pull request addresses the following changes:

  • Fixed a bug where the interface would throw an error when the input request parameter was in the format of List.
  • Changed the default HOST from localhost to 0.0.0.0 to allow external access.
  • Modified the default value of NORMALIZE_EMBEDDINGS to True.
  • Fixed an issue where the HuggingFaceBgeEmbeddings couldn't be called when loading a local model.
  • When no model name is provided, it now defaults to the model defined in DEFAULT_MODEL_NAME.
  • Added attributes to the returned class to maintain consistency with the OpenAI format.
  • Added the dependency "uvicorn" for service startup.
  • Improved Python version compatibility (tested with Python 3.8 to Python 3.10) by switching methods between **request.model_dump and **request.dict based on the differences in pydantic versions.

Please review and merge this pull request at your earliest convenience. Thank you!

@limcheekin
Copy link
Owner

Thanks for sending the PR. I will take the time to review and test it out. Please don't force push changes to main branch.

@jayxuz
Copy link
Contributor Author

jayxuz commented Oct 23, 2023

Thanks for sending the PR. I will take the time to review and test it out. Please don't force push changes to main branch.

Thanks for review .
Sorry about force push , I submitted the wrong code ,so used force push to overwrite my own wrong code.

@limcheekin
Copy link
Owner

I will merge the changes except the commit of fix List Post Error

Copy link
Owner

@limcheekin limcheekin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment.

open/text/embeddings/server/app.py Outdated Show resolved Hide resolved
@limcheekin limcheekin merged commit a258172 into limcheekin:main Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants