Added support for direct initialization

[apollo13]

This is a re-implementation of #14 without any backwards incompatible changes (aside from a pydantic version increase)

[apollo13]

This requires Pydantic 1.7, if this is not okay for you then I can work around this.

[codecov-commenter]

Codecov Report

Merging #23 (19673f7) into main (993d745) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          437       482   +45     
  Branches        50        52    +2     
=========================================
+ Hits           437       482   +45     

Impacted Files	Coverage Δ
goodconf/__init__.py	100.00% <100.00%> (ø)
goodconf/contrib/django.py	100.00% <100.00%> (ø)
tests/test_files.py	100.00% <100.00%> (ø)
tests/test_goodconf.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ipmb]

Are we sure 2.0 will be breaking for our use case? I'm hesitant to add the upper version restriction.

[ipmb]

Could you document the precedence here in the README?

[apollo13]

I just looked at the README and it already documents the precedence of env over files. I'd prefer not to document anything else currently and wait to see if pydantic 2 would require further changes. In the same sense I would not document initialization via __init__ now. Everyone using this library and knows pydantic can use it, but let's wait and see what pydantic 2 does before making this an official feature.

[apollo13]

Will document the precedence. But just so there is no misunderstanding, for all intents and purposes the precedence stays as it was before. That is ENV wins over file.cfg and initialization wins over everything else (which wasn't possible before). As for the pydantic version boundary: will remove it, we can always issue a new release if we find out that 2.0 is not compatible.

…

On Wed, Jan 11, 2023, at 22:14, Peter Baumgartner wrote: ***@***.**** commented on this pull request. In goodconf/__init__.py <#23 (comment)>: > @@ -94,34 +127,21 @@ def customise_sources( file_secret_settings: SettingsSourceCallable, ) -> Tuple[SettingsSourceCallable, ...]: """Load environment variables before init""" - return env_settings, init_settings, file_secret_settings - - def load(self, filename: str = None) -> None: + return ( + init_settings, + env_settings, + file_config_settings_source, + file_secret_settings, + ) Could you document the precedence here in the README? — Reply to this email directly, view it on GitHub <#23 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAT5C4BCBG6PUFFLWER5JDWR4PD5ANCNFSM6AAAAAATUSPLFU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[ipmb]

@apollo13 could you update CHANGES.rst and I can cut a new release? We should probably call this 2.1.0