Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for older pythons #39

Merged
merged 0 commits into from
Feb 10, 2024
Merged

Patch for older pythons #39

merged 0 commits into from
Feb 10, 2024

Conversation

ipmb
Copy link
Member

@ipmb ipmb commented Feb 10, 2024

some types don't have a __name__ attribute

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c43b919) 100.00% compared to head (a93ab42) 98.63%.
Report is 9 commits behind head on main.

Files Patch % Lines
goodconf/__init__.py 69.56% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #39      +/-   ##
===========================================
- Coverage   100.00%   98.63%   -1.37%     
===========================================
  Files            9        9              
  Lines          482      512      +30     
  Branches        52       57       +5     
===========================================
+ Hits           482      505      +23     
- Misses           0        4       +4     
- Partials         0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ipmb ipmb merged commit a93ab42 into main Feb 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants