Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to specify pull request assignees #194

Closed
Sam13 opened this issue Oct 7, 2021 · 6 comments · Fixed by #196
Closed

Ability to specify pull request assignees #194

Sam13 opened this issue Oct 7, 2021 · 6 comments · Fixed by #196
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Sam13
Copy link

Sam13 commented Oct 7, 2021

I think it would be a good enhancement to optionally specify pull request assignees (and not just reviewers).
@lindell
Copy link
Owner

lindell commented Oct 7, 2021

Agreed that is would be useful 🙂

I would be happy to accept a PR with these changes.

@lindell lindell added enhancement New feature or request good first issue Good for newcomers labels Oct 7, 2021
@Berreek
Copy link
Contributor

Berreek commented Oct 10, 2021

I would like to take this one.

However for GitHub I do not see the option to set assignees trough API (unless I'm missing something really obvious there). Rest of providers are fine as far as I saw.

@lindell
Copy link
Owner

lindell commented Oct 10, 2021

I took a look as well @Berreek. And as you said, there exists nothing under the obvious place of pull request operations.

But I think where you add it is under "add assignees to issue" since pull requests are treated as a special kind of issue in GitHub.
https://pkg.go.dev/github.com/google/go-github/v39/github#IssuesService.AddAssignees

I have not confirmed this yet, but I'm pretty certain it's the operation to use.

Berreek pushed a commit to Berreek/multi-gitter that referenced this issue Oct 14, 2021
feat: add possibility to add assignees to pull request (lindell#194)
6d18909 
Add parameter assignees (-a) to the pull request command that allows to specify assignees usernames that should be added to the created pull request.
@Berreek Berreek mentioned this issue Oct 14, 2021
Merged
2 tasks
@Berreek
Copy link
Contributor

Berreek commented Oct 14, 2021

I prepared a draft PR #196. I was not able to test it yet - will do it over the weekend prolly.
Also added the note regarding the GitLab implementation there.

@lindell
Copy link
Owner

lindell commented Oct 20, 2021

Thanks @Berreek for the addition 💚

@lindell
Copy link
Owner

lindell commented Oct 20, 2021

Released in v0.35.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add possibility to add assignees to pull request Berreek/multi-gitter
3 participants
@lindell @Sam13 @Berreek