feat: filter repositories that are forks #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for filtering out repositories that are forks. See #340.
lindell
reviewed
Apr 7, 2023
internal/scm/gitea/repository.go
Outdated
| @@ -47,3 +49,7 @@ func (r repository) DefaultBranch() string { | |||
| func (r repository) FullName() string { | |||
| return fmt.Sprintf("%s/%s", r.ownerName, r.name) | |||
| } | |||
|
|
|||
| func (r repository) Fork() bool { | |||
There was a problem hiding this comment.
I assume this is a relic from when an implementation where the filtering was supposed to be done in the multigitter package instead? I would have been fine with that (only drawback is that there are potential that SCMs allow the filtering to be done at API level). But now this should be dead code?
There was a problem hiding this comment.
Same is true for the field in the repository struct?
Remove unused function.
Remove unused field.
lindell
approved these changes
Apr 9, 2023
|
Included in release v0.46.0 🎉 |
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Add support for filtering out repositories that are forks using
--skip-forks.What issue does it fix
See #340.
Notes for the reviewer
None.
Checklist