fix: cmdgit BranchExist should match full branch name #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavkj
changed the title
gustavkj
changed the title
gustavkj
changed the title
lindell
approved these changes
Nov 25, 2023
gustavkj
force-pushed
the
fix/cmdgit-should-match-full-branch-name
branch
from
6b65c33 to
6614064
Compare
This was referenced Jan 6, 2024
|
Included in release v0.49.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Makes
BranchExistincmdgitmatch the full branch name. Previously, it would incorrectly returntrueif an existing branch started with the same name as the configured branch inmulti-gitter.Notes for the reviewer
Added the test prior to implementing the fix and without the fix the test failed (as expected) when running with
--git-type cmd.Checklist