Add RequestContextStorage.hook()
#2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: There's currently no way to perform an additional operation on top of the `RequestContextStorage` implementation discovered via `ServiceLoader`. Modifications: - Added `RequestContextStorage.hook(Function)` so that a user is allowed to modify the current `RequestContextStorage`. - `RequestContextStorage` is now `Unwrappable`. - Added `RequestContextStorageWrapper` Result: - A user can install a custom hook in runtime, usually at startup time, like other frameworks.
ikhoon
reviewed
May 18, 2020
...t-storage/src/test/java/com/linecorp/armeria/common/CustomRequestContextStorageProvider.java
Show resolved
Hide resolved
ikhoon
approved these changes
May 18, 2020
minwoox
approved these changes
May 18, 2020
core/src/main/java/com/linecorp/armeria/common/RequestContextStorage.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2723 +/- ##
============================================
- Coverage 72.63% 72.59% -0.04%
+ Complexity 11621 11617 -4
============================================
Files 1022 1023 +1
Lines 45434 45446 +12
Branches 5662 5663 +1
============================================
- Hits 32999 32993 -6
- Misses 9532 9551 +19
+ Partials 2903 2902 -1 Continue to review full report at Codecov.
|
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: There's currently no way to perform an additional operation on top of the `RequestContextStorage` implementation discovered via `ServiceLoader`. Modifications: - Added `RequestContextStorage.hook(Function)` so that a user is allowed to modify the current `RequestContextStorage`. - `RequestContextStorage` is now `Unwrappable`. - Added `RequestContextStorageWrapper` Result: - A user can install a custom hook in runtime, usually at startup time, like other frameworks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There's currently no way to perform an additional operation on top of
the
RequestContextStorageimplementation discovered viaServiceLoader.Modifications:
RequestContextStorage.hook(Function)so that a user is allowedto modify the current
RequestContextStorage.RequestContextStorageis nowUnwrappable.RequestContextStorageWrapperResult:
like other frameworks.