Check if the internal project and repos exist before creating them #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Central Dogma server currently attempts to create internal projects and repositories during starting up, even if they already exist. This is unnecessary for most scenarios, except when setting up a new cluster. Modifications: - Added checks to verify if the internal project and repositories exist before attempting to create them. - Propagated the read-only exception to the caller if it's raised while creating the internal project. - It doesn't make sense to continue to run the cluster because the internal project must exist when the cluster gets back to non read-only mode. Result: - Central Dogma servers now checks for the existence of internal projects and repos before attempting to create them.
minwoox
commented
Aug 13, 2024
| "mirroringEnabled": true, | ||
| "numMirroringThreads": null, | ||
| "maxNumFilesPerMirror": null, | ||
| "maxNumBytesPerMirror": null, |
There was a problem hiding this comment.
Let me remove these broken properties for now.
We will introduce a build process to prevent this sort of mistakes later as described in
#1003
ikhoon
reviewed
Aug 16, 2024
| throw new Error("failed to initialize an internal project: " + projectName, peeled); | ||
| if (!projectManager.exists(projectName)) { | ||
| try { | ||
| executor.execute(createProject(creationTimeMillis, Author.SYSTEM, projectName)) |
There was a problem hiding this comment.
Suggestion: Could you wrap createProject() and createRepository() with forcePush() command to make it work in REPLICATION_ONLY mode?
There was a problem hiding this comment.
Good suggestion. Applied. 👍
ikhoon
reviewed
Aug 16, 2024
server/src/main/java/com/linecorp/centraldogma/server/command/Command.java
Show resolved
Hide resolved
|
The test failure in CI will be fixed by #1016 |
ikhoon
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Central Dogma server currently attempts to create internal projects and repositories during starting up, even if they already exist. This is unnecessary for most scenarios, except when setting up a new cluster.
Modifications:
Result: