Add a commit and compare view #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
Central Dogma UI does not provide a commit view or changes view between
revisions.
Modifications:
- Remove a history tab in a file editor and add a commit view button
instead.
- The history tab didn't have a deep link for it.
- As a result, we can't directly enter the history view from a URL
- Addtionally, the orignal page wasn't preserved when we navigated
pages back and forth.
- Add history view pages on `/app/projects/<proj>/repos/<repo>/commits`.
- Add a commit view page on
`/app/projects/<proj>/repos/<repo>/commit/<revision>
- Add a changes view page on
`/app/projects/<proj>/repos/<repo>/compare/<head-rev>/base/<base-rev>`
- Dependencies)
- Add prismjs 1.29.0 for syntax highlights for the diff view.
- Add react-diff-viewer-continued 3.4.0 for the beatiful diff UI.
Result:
You can now track changes using diff UI.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Central Dogma UI does not provide a commit view or changes view between revisions.
Modifications:
/app/projects/<proj>/repos/<repo>/commits./app/projects/<proj>/repos/<repo>/compare/<head-rev>/base/<base-rev>Result:
You can now track changes using diff UI.