Correctly copy CLI binaries to dist path #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
`dogma.{os}-{arch}` binaries were copied into
`dist/bin/native/{cli-version}/`. `dogma` script expects the binaries to be
in `dist/bin/native/` but `cli-version` was prepended.
Modifications:
- Specify `cli-version` when copying CLI binaries.
Result:
Correctly run CLI binaries with the `dogma` script.
Codecov ReportBase: 64.87% // Head: 65.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #748 +/- ##
============================================
+ Coverage 64.87% 65.20% +0.33%
- Complexity 3222 3267 +45
============================================
Files 349 350 +1
Lines 13474 13704 +230
Branches 1454 1485 +31
============================================
+ Hits 8741 8936 +195
- Misses 3905 3929 +24
- Partials 828 839 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
dogmascript expects the binaries to be indist/bin/native/butcli-versionwas appended.Hence,
dogma.{os}-{arch}binaries were copied intodist/bin/native/{cli-version}/anddogmascript failed to run.Modifications:
cli-versionwhen copying CLI binaries.Result:
Correctly run CLI binaries with the
dogmascript.