Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix message representation for signing #513

Merged
merged 11 commits into from
Apr 29, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Apr 22, 2022

Description

This PR change the msg incomming and outgoing data to contract.
It allows to input and output the actual json object to msg. This fix is based on CosmWasm/wasmd#658

Additionally, init_msg of MsgStoreCodeAndInstantiateContract is also changed to msg.

Motivation and context

The existing json.RawMessage is inconvenient because the part that needs to be used after converting json requires conversion when generating the actual tx.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #513 (5b95dcc) into main (396a1fe) will increase coverage by 0.04%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   56.75%   56.80%   +0.04%     
==========================================
  Files         777      777              
  Lines       83389    83369      -20     
==========================================
+ Hits        47331    47355      +24     
+ Misses      33004    32959      -45     
- Partials     3054     3055       +1     
Impacted Files Coverage Δ
x/wasm/client/cli/tx.go 14.54% <0.00%> (ø)
x/wasm/keeper/msg_server.go 0.00% <0.00%> (ø)
x/wasm/keeper/query_plugins.go 73.26% <40.00%> (-0.51%) ⬇️
x/wasm/types/tx.go 40.72% <69.23%> (+1.31%) ⬆️
x/wasm/keeper/legacy_querier.go 65.51% <80.00%> (ø)
x/wasm/keeper/querier.go 68.77% <100.00%> (+0.42%) ⬆️
x/wasm/types/proposal.go 81.14% <100.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/consortium/keeper/querier.go
... and 9 more

client/query_test.go Outdated Show resolved Hide resolved
@zemyblue zemyblue mentioned this pull request Apr 28, 2022
4 tasks
@zemyblue zemyblue merged commit a08a1ee into Finschia:main Apr 29, 2022
@zemyblue zemyblue deleted the wasm_rawmessage branch May 2, 2022 04:40
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants