fix: fix the data race problem in TestQueryABCIHeight
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 57.59% 57.58% -0.01%
==========================================
Files 793 793
Lines 86584 86584
==========================================
- Hits 49866 49861 -5
- Misses 33558 33562 +4
- Partials 3160 3161 +1
|
Signed-off-by: zemyblue <zemyblue@gmail.com>
dudong2
approved these changes
Jun 17, 2022
0Tech
approved these changes
Jun 28, 2022
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zemyblue zemyblue@gmail.com
Description
This data race problem of
TestQueryABCIHeightoccurs frequently.There are three times test continually in
TestQueryABCIHeight. In the last test, he origin expected block height is 4, but sometimes the test result is 5. I think this reason is that the block confirm time is very short(1s) and it seems to be affected by previous tests and CI system spec. So, increase the expected value by 1 and modify the test to succeed if the block height is below that value.related: #514
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml,