ChannelAccessToken client doesn't have to require channel access token #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
force-pushed
the
channel-access-token-doesnt-require-auth-token
branch
from
1615c59
to
2172d20
Compare
Yang-33
commented
Nov 17, 2023
Comment on lines
89
to
98
| grant_type: grantType, | ||
| code: code, | ||
| redirectUri: redirectUri, | ||
| codeVerifier: codeVerifier, | ||
| clientId: clientId, | ||
| clientSecret: clientSecret, | ||
| redirect_uri: redirectUri, | ||
| code_verifier: codeVerifier, | ||
| client_id: clientId, | ||
| client_secret: clientSecret, | ||
| region: region, | ||
| basicSearchId: basicSearchId, | ||
| basic_search_id: basicSearchId, | ||
| scope: scope, | ||
| brandType: brandType, | ||
| brand_type: brandType, |
There was a problem hiding this comment.
There was a problem hiding this comment.
We discussed this internally, I'll submit change as other PR.
tokuhirom
reviewed
Nov 20, 2023
| {% endfor %} | ||
| }; | ||
| // Remove properties with undefined or empty values |
There was a problem hiding this comment.
Why was this change included in this commit?
There was a problem hiding this comment.
Let me remove this~
tokuhirom
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.