Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated dependency: androidx.lifecycle:lifecycle-extensions #166

Merged
merged 2 commits into from
May 8, 2024

Conversation

YkSix
Copy link
Contributor

@YkSix YkSix commented May 8, 2024

Description

  1. Remove deprecated dependency: androidx.lifecycle:lifecycle-extensions
    The last version of it is v2.2.0
    https://mvnrepository.com/artifact/androidx.lifecycle/lifecycle-extensions

  2. Quoted from lifecycle_documents:

The APIs in lifecycle-extensions have been deprecated. Instead, add dependencies for the specific Lifecycle artifacts you need.

  1. Deprecated lifecycle-extensions dependency led to issue: Could not find androidx.lifecycle:lifecycle-extensions:2.5.0. flutter_line_sdk#93

  2. Bump the version of lifecycle-viewmodel-ktx from 2.2.0 to 2.4.0 because of the "Duplicate class issue" when rebuilding the project:

> Task :line-sdk:checkDebugAndroidTestDuplicateClasses FAILED
Duplicate class ViewModelLazy found in modules jetified-lifecycle-viewmodel-ktx-2.2.0-runtime and lifecycle-viewmodel-2.4.0-runtime

In the LINE SDK v5.10.0, it already implicitly uses "v2.4.0" of lifecycle libraries. the "v2.4.0" dependency is from databinding:7.3.1

./gradlew line-sdk:dependencies

+--- androidx.databinding:databinding-ktx:7.3.1
|    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.4.0
|    +--- androidx.lifecycle:lifecycle-livedata:2.4.0

YkSix added 2 commits May 2, 2024 14:46
It fixes the below issue:

> Task :line-sdk:checkDebugAndroidTestDuplicateClasses FAILED

Duplicate class ViewModelLazy found in modules jetified-lifecycle-viewmodel-ktx-2.2.0-runtime and lifecycle-viewmodel-2.4.0-runtime
@YkSix YkSix requested review from plateaukao and tsairene May 8, 2024 04:38
Copy link
Contributor

@tsairene tsairene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsairene tsairene merged commit 467b6a1 into line:master May 8, 2024
3 checks passed
@YkSix YkSix deleted the remove_lifecycle-extensions branch May 8, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants