Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Implement sender whitelist filters #132

Merged
merged 3 commits into from
Mar 11, 2019
Merged

[FEATURE] Implement sender whitelist filters #132

merged 3 commits into from
Mar 11, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Mar 6, 2019 •
edited
Loading

  • senders with no filters will allow everything to pass
  • senders with filters enabled will check labels for whitelist

notification

@codecov-io
Copy link

codecov-io commented Mar 6, 2019 •
edited
Loading

Codecov Report

Merging #132 into master will increase coverage by 0.11%.
The diff coverage is 43.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   45.94%   46.06%   +0.11%     
==========================================
  Files          38       39       +1     
  Lines        2407     2462      +55     
==========================================
+ Hits         1106     1134      +28     
- Misses       1301     1328      +27
Impacted Files Coverage Δ
promgen/admin.py 0% <0%> (ø) ⬆️
promgen/templatetags/promgen.py 43.15% <0%> (ø) ⬆️
promgen/tasks.py 100% <100%> (ø) ⬆️
promgen/forms.py 94.62% <100%> (+0.24%) ⬆️
promgen/migrations/0007_message_filter.py 100% <100%> (ø)
promgen/views.py 48.05% <20.83%> (-0.95%) ⬇️
promgen/models.py 29.28% <50%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816b1d2...e14a7a8. Read the comment docs.

@kfdm kfdm force-pushed the filter-messages branch from 95684ce to 92601ab Compare March 6, 2019 06:29
kfdm added 2 commits March 7, 2019 15:27
@kfdm
Update test cases with severity label included
32fcd87
@kfdm
Stubs
ba8ba0e 
Initial server implementation

Admin panel updates for testing

Fix filter model unique fields
@kfdm kfdm force-pushed the filter-messages branch from 92601ab to 0b86198 Compare March 7, 2019 06:43
@kfdm kfdm changed the title Filter messages [FEATURE] Implement sender whitelist filters Mar 8, 2019
@kfdm kfdm requested a review from m-tkg March 8, 2019 06:21
@kfdm kfdm marked this pull request as ready for review March 8, 2019 06:21
@m-tkg m-tkg requested a review from Asuforce March 8, 2019 07:37
@kfdm kfdm force-pushed the filter-messages branch from 0b86198 to 5bc6b42 Compare March 8, 2019 07:46
Asuforce
Asuforce approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@Asuforce Asuforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-tkg
m-tkg reviewed Mar 8, 2019
View reviewed changes
promgen/urls.py Show resolved Hide resolved
@kfdm
Implement sender whitelist filters
e14a7a8 
- senders with no filters will allow everything to pass
- senders with filters enabled will check labels for whitelist
@kfdm kfdm force-pushed the filter-messages branch from 5bc6b42 to e14a7a8 Compare March 11, 2019 05:42
@kfdm kfdm merged commit 5631e64 into line:master Mar 11, 2019
@kfdm kfdm deleted the filter-messages branch March 11, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-tkg m-tkg m-tkg left review comments

@Asuforce Asuforce Asuforce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kfdm @codecov-io @m-tkg @Asuforce