Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Move remaining celery tasks to tasks.py #139

Merged
merged 1 commit into from
May 29, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Apr 5, 2019

More cleanly split tasks.py and prometheus.py in preparation for additional cleanup and refactoring

@kfdm kfdm requested a review from m-tkg April 5, 2019 06:51
@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #139 into master will increase coverage by 0.32%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   46.63%   46.95%   +0.32%     
==========================================
  Files          41       41              
  Lines        2464     2462       -2     
==========================================
+ Hits         1149     1156       +7     
+ Misses       1315     1306       -9
Impacted Files Coverage Δ
promgen/signals.py 27.67% <0%> (+0.34%) ⬆️
promgen/views.py 48.28% <0%> (ø) ⬆️
promgen/prometheus.py 67.3% <0%> (+9.69%) ⬆️
promgen/tasks.py 39.72% <17.77%> (-60.28%) ⬇️
promgen/celery.py 73.91% <0%> (+69.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f27103...55faee4. Read the comment docs.

@kfdm kfdm requested a review from Asuforce April 11, 2019 06:45
@kfdm kfdm force-pushed the task-refactor branch from acf8193 to 55faee4 Compare May 29, 2019 01:50
@kfdm kfdm merged commit f08d5ae into line:master May 29, 2019
@kfdm kfdm deleted the task-refactor branch May 29, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants