Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unittests #166

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Refactor unittests #166

merged 1 commit into from
Oct 2, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Aug 14, 2019 •
edited
Loading

  • Remove dependency on factory_boy
  • Add assertRoute for checking routes and redirects
  • Add add_force_login to simplfy auth checks

@codecov-io
Copy link

codecov-io commented Aug 14, 2019 •
edited
Loading

Codecov Report

Merging #166 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   47.11%   47.05%   -0.07%     
==========================================
  Files          43       43              
  Lines        2424     2425       +1     
==========================================
- Hits         1142     1141       -1     
- Misses       1282     1284       +2
Impacted Files Coverage Δ
promgen/views.py 49.85% <0%> (-0.29%) ⬇️
promgen/templatetags/promgen.py 40.2% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5b7d7...7eda995. Read the comment docs.

@kfdm
Refactor unittests
7eda995 
- Remove dependency on factory_boy
- Add assertRoute for checking routes and redirects
- Add add_force_login to simplfy auth checks
@kfdm kfdm force-pushed the testcase-cleanup branch from 1644feb to 7eda995 Compare October 2, 2019 01:44
@kfdm kfdm changed the title Testcase cleanup Refactor unittests Oct 2, 2019
@kfdm kfdm requested a review from m-tkg October 2, 2019 01:45
@kfdm kfdm marked this pull request as ready for review October 2, 2019 01:46
@kfdm kfdm merged commit 631cc46 into line:master Oct 2, 2019
@kfdm kfdm deleted the testcase-cleanup branch October 2, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-tkg m-tkg m-tkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kfdm @codecov-io @m-tkg