Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to the correct request method #185

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

shokada
Copy link
Contributor

@shokada shokada commented Oct 10, 2019

The request method of /api/v1/alerts is POST.
https://github.com/line/promgen/blob/master/promgen/views.py#L1034

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ee9547d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage          ?   47.26%           
=========================================
  Files             ?       43           
  Lines             ?     2435           
  Branches          ?        0           
=========================================
  Hits              ?     1151           
  Misses            ?     1284           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9547d...e296318. Read the comment docs.

Copy link

@m-tkg m-tkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-tkg m-tkg requested a review from kfdm October 10, 2019 04:48
@kfdm kfdm merged commit 09fa5c5 into line:master Oct 10, 2019
@kfdm
Copy link
Collaborator

kfdm commented Oct 10, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants