Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Rule.content_object should use our Site proxy module #194

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Nov 8, 2019

Since we define most of our relations on our local proxy Site module,
we want to ensure our lookup does the same.

Since we define most of our relations on our local proxy Site module,
we want to ensure our lookup does the same.
@kfdm kfdm requested a review from m-tkg November 8, 2019 08:32
@codecov-io
Copy link

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files          44       44           
  Lines        2471     2471           
=======================================
  Hits         1181     1181           
  Misses       1290     1290
Impacted Files Coverage Δ
promgen/models.py 29.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6a4d3...ad54be5. Read the comment docs.

@kfdm kfdm merged commit 7952efa into line:master Nov 8, 2019
@kfdm kfdm deleted the fix-rule-list-page branch November 8, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants