Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixes to unit tests to avoid signal errors #216

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Dec 11, 2019

  • Fix mocking our signal handlers
  • Run isort and minor cleanup on unittests

@kfdm kfdm requested a review from shokada December 11, 2019 09:53
@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files          48       48           
  Lines        2584     2584           
=======================================
  Hits         1192     1192           
  Misses       1392     1392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35441dd...45f6b73. Read the comment docs.

- Fix mocking our signal handlers
- Run isort and minor cleanup on unittests
@kfdm kfdm merged commit db582be into line:master Dec 12, 2019
@kfdm kfdm deleted the unittest-cleanup branch December 12, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants