Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Start refactoring api into /rest/ namespace #224

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Dec 13, 2019

  • Rename /api to /rest for Promgen specific endpoints
  • Add /rest/all/rules to replace /api/v1/rules to export all rules

- Rename `/api` to `/rest` for Promgen specific endpoints
- Add `/rest/all/rules` to replace `/api/v1/rules` to export all rules
@kfdm kfdm added this to the 2020 Q1 Cleanup and Features milestone Dec 13, 2019
@kfdm kfdm requested a review from shokada December 13, 2019 06:21
@kfdm kfdm self-assigned this Dec 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #224 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   46.19%   46.22%   +0.02%     
==========================================
  Files          48       48              
  Lines        2578     2583       +5     
==========================================
+ Hits         1191     1194       +3     
- Misses       1387     1389       +2
Impacted Files Coverage Δ
promgen/rest.py 75% <66.66%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e532bde...9a6008b. Read the comment docs.

@kfdm kfdm merged commit 3b269d0 into line:master Dec 20, 2019
@kfdm kfdm deleted the rest-api-refactor branch December 20, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants