Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Add validation to Shard, Service, Project, and Farm name #228

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jan 16, 2020

No description provided.

@kfdm kfdm requested a review from shokada January 16, 2020 06:38
@codecov-io
Copy link

Codecov Report

Merging #228 into master will increase coverage by 0.12%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   46.22%   46.34%   +0.12%     
==========================================
  Files          48       49       +1     
  Lines        2583     2589       +6     
==========================================
+ Hits         1194     1200       +6     
  Misses       1389     1389
Impacted Files Coverage Δ
promgen/models.py 28.84% <0%> (ø) ⬆️
promgen/migrations/0012_validation_updates.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a0467...bd4dab6. Read the comment docs.

@kfdm kfdm merged commit dae2b72 into line:master Jan 16, 2020
@kfdm kfdm deleted the object-name-validation branch January 16, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants