Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix test data for notifier test #257

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Mar 11, 2020

The test classes were refactored in #243 but this instance was missed

The test classes were refactored in line#243 but this instance was missed
@kfdm kfdm requested a review from shokada March 11, 2020 07:15
@codecov-io
Copy link

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   47.11%   47.11%           
=======================================
  Files          54       54           
  Lines        2630     2630           
=======================================
  Hits         1239     1239           
  Misses       1391     1391
Impacted Files Coverage Δ
promgen/models.py 28.72% <0%> (ø) ⬆️
promgen/views.py 48.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8f12f...e6de74b. Read the comment docs.

@kfdm kfdm merged commit e566543 into line:master Mar 11, 2020
@kfdm kfdm deleted the notifier-test-fix branch March 11, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants