Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle button for notifier #258

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Add toggle button for notifier #258

merged 3 commits into from
Mar 19, 2020

Conversation

shokada
Copy link
Contributor

@shokada shokada commented Mar 16, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #258 into master will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   47.11%   47.12%   +0.01%     
==========================================
  Files          54       55       +1     
  Lines        2630     2642      +12     
==========================================
+ Hits         1239     1245       +6     
- Misses       1391     1397       +6     
Impacted Files Coverage Δ
promgen/models.py 28.64% <0.00%> (-0.08%) ⬇️
promgen/urls.py 94.44% <ø> (ø)
promgen/views.py 47.92% <28.57%> (-0.20%) ⬇️
promgen/forms.py 92.45% <100.00%> (ø)
promgen/migrations/0018_sender_enabled.py 100.00% <100.00%> (ø)
promgen/tasks.py 46.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e566543...0d877f1. Read the comment docs.

promgen/views.py Outdated Show resolved Hide resolved
promgen/migrations/0018_sender_enabled.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kfdm kfdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@kfdm kfdm merged commit 7b2481e into line:master Mar 19, 2020
kfdm added a commit to kfdm/promgen that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants