Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing scheme on default exporter #259

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Mar 16, 2020

  • Move some fields to a BaseExporter class that can be used by both
    DefaultExporter and Exporter to keep the fields synced

- Move some fields to a BaseExporter class that can be used by both
  DefaultExporter and Exporter to keep the fields synced
@kfdm kfdm added the bug label Mar 16, 2020
@kfdm kfdm requested a review from shokada March 16, 2020 08:24
@codecov-io
Copy link

Codecov Report

Merging #259 into master will increase coverage by 0.15%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   47.11%   47.26%   +0.15%     
==========================================
  Files          54       55       +1     
  Lines        2630     2630              
==========================================
+ Hits         1239     1243       +4     
+ Misses       1391     1387       -4
Impacted Files Coverage Δ
promgen/models.py 29.03% <0%> (+0.3%) ⬆️
promgen/migrations/0018_default_exporter_scheme.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e566543...78cad37. Read the comment docs.

@kfdm kfdm self-assigned this Mar 16, 2020
@kfdm kfdm merged commit 4b7b58f into line:master Mar 16, 2020
@kfdm kfdm deleted the default-exporter-scheme branch March 16, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants