Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporter test #263

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Fix exporter test #263

merged 3 commits into from
Mar 31, 2020

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Mar 31, 2020

  • Query based on project.id (instead of farm.id) for future refactoring
  • Change from form to regular POST data to avoid extra validation confusion
  • Simplify exporter-test button html

@kfdm kfdm requested a review from shokada March 31, 2020 01:38
@kfdm kfdm added the bug label Mar 31, 2020
@codecov-io
Copy link

Codecov Report

Merging #263 into master will decrease coverage by 0.05%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   47.20%   47.14%   -0.06%     
==========================================
  Files          56       56              
  Lines        2646     2647       +1     
==========================================
- Hits         1249     1248       -1     
- Misses       1397     1399       +2     
Impacted Files Coverage Δ
promgen/urls.py 94.44% <ø> (ø)
promgen/views.py 47.78% <72.72%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb5aff5...23f6658. Read the comment docs.

@kfdm kfdm merged commit 17034c5 into line:master Mar 31, 2020
@kfdm kfdm deleted the fix-exporter-test branch March 31, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants