Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Hostname validator based off URLValidator #383

Merged
merged 2 commits into from
Jan 25, 2022
Merged

[BUGFIX] Hostname validator based off URLValidator #383

merged 2 commits into from
Jan 25, 2022

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jan 24, 2022 •
edited
Loading

Our previous fix (in #380) was too naive, and forgets . and other characters that can be in a hostname. May be better to base it on the existing URLValidator

@kfdm kfdm self-assigned this Jan 24, 2022
@kfdm kfdm marked this pull request as ready for review January 25, 2022 03:22
@kfdm kfdm requested a review from a team as a code owner January 25, 2022 03:22
@kfdm kfdm merged commit 22801ea into line:master Jan 25, 2022
@kfdm kfdm deleted the hostname-fix branch January 25, 2022 05:00
@kfdm kfdm mentioned this pull request Feb 4, 2022
Merged
kfdm added a commit that referenced this pull request Feb 4, 2022
@kfdm
[BUGFIX] Update validator to allow hostname only entries #386
f962eaf 
One more attempt to fix the edge cases for validating hostnames. We want to allow bare hostnames and fqdn, but not allow any other special characters like an accidental port or path part

References #383 #380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asuforce Asuforce Asuforce approved these changes

Assignees

@kfdm kfdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfdm @Asuforce