Uniform register buttons #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option in the drop down menu correctly says "Register Project". However, in the form for registering a new project, the button that executes the action was saying "Project Register".
The text in the button for registering a farm said "New Farm". However, that was not consistent with the "Register <item>" pattern used in the other buttons, so we have changed it.
|
|
kfdm
reviewed
May 27, 2022
|
I have added 8e48d4f to fix the button text capitalization. It's a fixup for the commit that changed the button text. |
kfdm
reviewed
May 30, 2022
|
All comments addressed. |
vincent-olivert-riera
force-pushed
the
uniform-register-buttons
branch
from
55e9d76 to
faeaa76
Compare
kfdm
reviewed
May 31, 2022
kfdm
reviewed
May 31, 2022
kfdm
approved these changes
May 31, 2022
The text in the button for registering new hosts said "Add new host". That had two problems: - Multiple hosts can be added at the same time, so "host" (in singular) was not correct. - The text was not consistent with the "Register <item>" pattern used in the other buttons.
There is a translation available for this button, however the "trans" function was not used to translate the button text.
vincent-olivert-riera
force-pushed
the
uniform-register-buttons
branch
from
073e944 to
6322726
Compare
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.