Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix handling of kwargs in skip_raw decorator #396

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

kfdm
Copy link
Collaborator

@kfdm kfdm commented Jun 13, 2022

When calling post_save with Service, we call out to save_project, but
did not handle some of our required parameters correctly

  • Change functions to all kwargs to hopefully catch errors in the future
  • Default raw=False in our wrapper to match post_save.send

When calling post_save with Service, we call out to save_project, but
did not handle some of our required parameters correctly

- Change functions to all kwargs to hopefully catch errors in the future
- Default raw=False in our wrapper to match post_save.send
@kfdm kfdm self-assigned this Jun 13, 2022
@kfdm kfdm marked this pull request as ready for review June 13, 2022 05:27
@kfdm kfdm requested a review from a team as a code owner June 13, 2022 05:27
Copy link
Contributor

@vincent-olivert-riera vincent-olivert-riera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfdm kfdm merged commit d016c31 into line:master Jun 14, 2022
@kfdm kfdm deleted the skip-raw-decorator branch June 14, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants