Black #416
Merged
Black #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since black only supports pyproject.toml, we want to remove the related isort config to the same file. We set our max-line-length to 100 (up from the default 88) to give us a bit more space to edit things, without as much noise. migrations are mostly generated so we will have black ignore them for now. Our urls become somewhat inconsistent and unreadable even with 100 for a line length, so we set it to be excluded and manually run it with 128 while preparing this first pass. Commands run while building the PR black promgen/notification black promgen/discovery black promgen/management black promgen/tests black promgen/urls.py -l 128 black promgen/views.py black promgen # Last check
|
Rebase is done and added to blame ignore file. Should be good for review 🙇 |
vincent-olivert-riera
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the settings in 2565066
For the rest picked a subset and tried to break it up for review purpose.
Final cleanup will involve squashing all the black fixups and then adding an entry in .git-blame-ignore-revs before merge.