[INTERNAL] Migrate more tests to use fixtures #418
Conversation
Rewrite our alert rule tests to use our fixtures. This means that we no longer need to do as much setup in the individual test cases and can focus more on the specific logic we're testing. Because we're using a rule from a fixture, we also need to update our test template a bit.
Update our CLI tests to use our fixtures to ensure reproducible tests. We'll use cli- as a prefix for our objects to ensure they don't otherwise conflict with out fixture values.
| service = models.Service.objects.create(name="TestService") | ||
| _ = models.Project.objects.create(name="TestProject", service=service, shard=shard) | ||
| management.call_command("register-job", "TestProject", "example", 1234) | ||
| management.call_command("register-job", "test-project", "example", 1234) |
There was a problem hiding this comment.
We'll use cli- as a prefix for our objects to ensure they don't otherwise conflict with out fixture values.
In the test_register_job function we are using test-project and example. Shouldn't we do the same as in the test_register_host function and use cli-project and cli.example.com?
There was a problem hiding this comment.
So in one we're registering to an existing project (from the fixture) and one we are creating new jobs from the test. For the ones created by the test I added the cli- prefix. Should I try to reword things to be a bit more clear?
There was a problem hiding this comment.
So in one we're registering to an existing project (from the fixture) and one we are creating new jobs from the test. For the ones created by the test I added the
cli-prefix.
I see 👍🏻
Should I try to reword things to be a bit more clear?
No, I think it's fine as it is.
Previously we had several tests that used the Django ORM to populate data. Using fixtures should give us more reproducible test.