[INTERNAL] Remove envdir #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're deploying Promgen more often with a docker container, it is better to just rely on django-environ and remove the old dependency on envdir.
Ensure that we're reading the actual path we want, instead of the current directory we happen to be in.
Ultimately we will retire this command, but for now we will remove the settings manipulation since that is now handled via a .env file instead of envdir. We will remove the bootstrap command (or revisit it) at the same time we update first-install/development instructions.
vincent-olivert-riera
requested changes
Sep 25, 2023
Since we're no longer setting a random secret key, we need to ensure that our docker build step sets something to prevent throwing an error.
vincent-olivert-riera
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have django-environ and we have been moving to a docker deployment, it doesn't make sense to keep envdir around anymore. This PR cleans up the initial bits, though we'll also have a future PR to cleanup the
promgen bootstrapcommand more.