Remove readthedocs in favor of Github actions and gh-pages #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-olivert-riera
requested changes
Nov 2, 2023
There was a problem hiding this comment.
There is an issue with the URL that needs fixing. At the same time, you may use this opportunity to fix a couple of things in the commit message:
Since our readthedocs build is current broken anyways
"current" -> "currently"
better to promote the github pages version as canotical
"canotical" -> "canonical"
In line#444 the github actions was fixed to publish to gh-pages properly. Since our readthedocs build is currently broken anyways, it is probably better to promote the github pages version as canonical since that will also result in less of a maintenance burden for other contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #444 the github actions was fixed to publish to gh-pages properly. Since our readthedocs build is current broken anyways, it is probably better to promote the github pages version as canotical since that will also result in less of a maintenance burden for other contributors.