Retries for notifications #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is a thin wrapper of the existing util::post function but with a retry mechanism that depends on the response's status code. This function can be used by our notifiers so we can retry sending a notification if, for instance, we have received a "Too Many Requests (429)" the first time.
Some times the end points are having temporary issues and return an error response, so retrying after some time could increase the chance of getting the notification delivered.
Some times the end points are having temporary issues and return an error response, so retrying after some time could increase the chance of getting the notification delivered.
Some times the end points are having temporary issues and return an error response, so retrying after some time could increase the chance of getting the notification delivered.
After clicking the notifier test button, it can take some time until the request is processed, the response is received and the whole form submission ends up on a page refresh. Because of that potential delay, the users may think that they did not click the button properly and try to click it again. To avoid that situation we have added some UI feedback so when the users click the test button, it gets disabled so they cannot click it again, and also its text changes to "Testing..." to clearly state that the test is ongoing. The corresponding localization for "Testing" has also been added.
|
Need to check why the tests are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.