Handle query for the audit logs of deleted objects #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an object is deleted, the current code cannot find the object or its related objects, and causes an error in the Audit Log feature when we try to filter that object. In that case, we directly use the object_id and content_type_id fields of the Audit model to find it and skip finding the related objects.
vincent-olivert-riera
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an object is deleted, the current code cannot find the object or its related objects, and causes an error in the Audit Log feature (Edit History) when we try to filter that object. In that case, we directly use the object_id and content_type_id fields of the Audit model to find it and skip finding the related objects.
AS-IS:
TO-BE:
