Added condition that makes OAuth authentication optional #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adicionei uma condição no settings.py para só habilitar o github oauth caso a variavel SOCIAL_AUTH_GITHUB_ORG_KEY tenha valor.
Deixei no env_template a variavel comentada por default. isso é para facilicar o ambiente do desenvolvedor que não precisar ter o OAuth configurado e também o ambiente de testes automatizados.
Importante Alterei as variaveis de config do banco, substitui SQL_ por DB_ só para ficar igual aos outros apps.