Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #187 - fixed the error that was occurring when trying to upload #193

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

jandsonrj
Copy link
Member

Fixed the error that was occurring when trying to upload a .pq file.

the error was being caused due to trying to access res.response.status directly after a .catch() without checking if the response property exists in the error object.

@jandsonrj jandsonrj added the bug Something isn't working label Aug 24, 2023
@jandsonrj jandsonrj linked an issue Aug 24, 2023 that may be closed by this pull request
Copy link
Member

@gschwend gschwend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with large parquet file

@glaubervila glaubervila merged commit 990080a into main Sep 15, 2023
3 checks passed
@glaubervila glaubervila deleted the 187-bug-in-upload branch September 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in upload
3 participants