-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve frameless window on windows #1324
Conversation
Played around with this a bit in a VM and wasn't able to really see any visual difference with |
The difference here is tiny. The other thing is resizing, and there is a few different things here: (This could potentially be different on other systems?) Using In borderless mode the best option might actually be to use I tried to make some recordings to show the resizing differences but the recording software was not good at capturing it, I might try some different software later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really just not up on the windows side enough to offer much useful feedback. Given that, and given that I don't see any actual regressions when playing around, I'm inclined to defer to you.
@rhzk I've invited you as a collaborator on the druid repo, so feel free to merge your own approved PRs and also to provide approving reviews of others' PRs in circumstances where you feel comfortable doing so. :) |
Thanks for the invite @cmyr. I will let this PR simmer a bit more, just in case I might realize a better or simpler way to do something or something I missed. |
sounds good! |
Some changes to the frameless window on windows, reducing the resize artifacts and the behavior is more simular to electron.
Added a wrapper function for GetSystemMetric since it ended up being called a lot