-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding protections for invalid flex parameters #1691
Conversation
- there is still more work to do to figure out how Flex children use 0.0 flex value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple notes inline :)
I opted to keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few little formatting nits, but happy to see this merged. :)
What's the conclusion here? |
In regards to what? Are there any other issues? The only one that came up was the tracing events need a subscriber created before the app is launched but that is a separate issue. oh oops, I'm going to take out the tracing instrument for the add flex child function. I forgot. Other than that I think everything is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ok, not sure if there are better ways to clamp a value above a certain threshold. Also, is it fine to do the tests like that? I had to do it that way otherwise the test fails in release and passes debug.