-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change simple code in book #1698
Conversation
@@ -58,6 +58,8 @@ You can find its changes [documented below](#070---2021-01-01). | |||
|
|||
### Docs | |||
|
|||
- Fix example code in `Get started with Druid` chapter of book ([#1698] by [@ccqpein]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add to the list of links at the bottom of the file for the [#1698]
and [@ccqpein]
shortcuts to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for notifying me, let me change it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just done. Please check it out.
Thanks! I'll merge this tomorrow morning if there are no other comments. |
This change causes the example code to no longer compile with I realize users of master branch can run into this without this change #1637, but the book doesn't currently specify using a git version. Should this be reverted? |
Based on this Zulip conversation, I've opened a PR (#1732) to update the book to use the latest git version. This was an oversight when I reviewed this PR. Sorry for the confusion it caused! |
In
Get started with Druid
of book, the simple code:doesn't pass the compiler. Change it to:
will work