Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cbondurant reported in #2355 that the docs for
Widget
andLensExt
are missing. Indeed that is the case, as is forLens
,WidgetId
, andWidgetExt
. I think I checked these just a month ago, and regardless I'm confident that these used to work way earlier, with no code/attribute changes since then.My best guess is that
rustdoc
changed how#[doc(hidden)]
is inherited. The way we use this attribute is to hide the docs in thewidget
module but then show them in the re-exported root module. This no longer works and the docs are hidden in the root too. Interestingly the reverse is still possible, we could hide the docs in the root but have them show up in thewidget
module.In this PR I decided to just have the docs visible in both the
widget
module and the root module. We're only talking a few traits here and they're quite fundamental.Additionally, I made two adjacent changes.
Env
) show up as inline docs, not as re-exports.Fixes #2355