Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually close GTK windows #797

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

luleyleo
Copy link
Collaborator

@luleyleo luleyleo commented Apr 3, 2020

Instead of removing the window from the application, it now gets closed.
This Closes #464 and also fixes the multiwin example with GTK.
Closing a window will also remove it from the Application

@ForLoveOfCats
Copy link
Collaborator

I'm currently testing this in relation to #464 but I do have a question in the meantime. What specifically about the multiwin example does this fix? It doesn't fix the context menu crash and I cannot find anything else about it which happens to be broken under GTK on master.

@luleyleo
Copy link
Collaborator Author

luleyleo commented Apr 3, 2020

@ForLoveOfCats The close item in the file menu did not work (as it works exactly like a custom close button)

Copy link
Collaborator

@ForLoveOfCats ForLoveOfCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah-ha, very nice. Does what it says on the tin and the change makes sense

@cmyr
Copy link
Member

cmyr commented Apr 3, 2020

Thanks both!

@cmyr cmyr merged commit d6b5b84 into linebender:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't close a window with a custom button
3 participants