Improve Windows invalidation logging. #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xStrom
force-pushed
the
invalidate-review
branch
from
abbc4a6
to
d160acf
Compare
Zarenor
approved these changes
May 5, 2020
Comment on lines
+81
to
+84
| fn destroy(&mut self) { | ||
| Application::global().quit() | ||
| } | ||
|
|
There was a problem hiding this comment.
This looks unrelated - I assume this is for some future further additions to this example?
There was a problem hiding this comment.
Well this invalidate example never quits when the window is closed. The other druid-shell examples quit on window closing. This simple change fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing the invalidation PR #817 and found room for a bit of improvement.