Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GTK folder selection with filters. #957

Merged
merged 2 commits into from
Jun 6, 2020
Merged

Fix GTK folder selection with filters. #957

merged 2 commits into from
Jun 6, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented May 17, 2020

This PR disables file filters when opening folders, because the filter makes it impossible to traverse in the folder structure.

Fixes #947.

@xStrom xStrom added shell/gtk concerns the GTK backend S-needs-review waits for review labels May 17, 2020
luleyleo
luleyleo reviewed May 17, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should log a warning in case someone tries to do this.
Also I think it would make sens to either enforce this on all platforms, or add documentation that there is no guarantee for filters to work with folders on any platform (besides macOS)?

@luleyleo luleyleo added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels May 18, 2020
@xStrom xStrom added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels May 29, 2020
@xStrom
Copy link
Member Author

xStrom commented May 29, 2020

After looking more deeply into it, filters don't really work on directories even on macOS. They work on packages instead. I cleaned up the API and added better docs in #960.

This PR now focuses on matching the newly documented API in behavior.

  • Directories don't get filtered here, and they don't get filtered on other platforms.
  • There's no logging of warnings, because specifying filters in a directory selection mode is legal. They are used to determine which paths are packages and which are directories. (The opposite of what was happening here.)

luleyleo
luleyleo approved these changes Jun 6, 2020
View reviewed changes
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering #960 this seems reasonable to me.

@luleyleo luleyleo removed the S-needs-review waits for review label Jun 6, 2020
@xStrom xStrom merged commit 9dbb27b into linebender:master Jun 6, 2020
@xStrom xStrom deleted the gtk-filters branch June 6, 2020 14:46
covercash2 pushed a commit to covercash2/druid that referenced this pull request Jun 13, 2020
@xStrom @covercash2
Fix GTK folder selection with filters. (linebender#957)
22edb63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luleyleo luleyleo luleyleo approved these changes

Assignees
No one assigned
Labels
shell/gtk concerns the GTK backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to filter directories on GTK file dialogs.
2 participants
@xStrom @luleyleo