Expose current_transform() for contexts #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholtzan
commented
Jan 19, 2020
| // todo | ||
| // current_transform() and get_transform() currently not implemented: | ||
| // https://github.com/rustwasm/wasm-bindgen/blob/f8354b3a88de013845a304ea77d8b9b9286a0d7b/crates/web-sys/webidls/enabled/CanvasRenderingContext2D.webidl#L136 | ||
| Affine::default() |
There was a problem hiding this comment.
I did open a PR to get this added: rustwasm/wasm-bindgen#1966
Not sure what the best way here is, wait until it's merged or return something like Affine::default() for now and change it later?
There was a problem hiding this comment.
yea this looks good. I would also open an issue when this is merged.
There was a problem hiding this comment.
rustwasm/wasm-bindgen#1966 got merged, now we'll just have to wait until a new version gets released to use it
cmyr
approved these changes
Jan 21, 2020
| // todo | ||
| // current_transform() and get_transform() currently not implemented: | ||
| // https://github.com/rustwasm/wasm-bindgen/blob/f8354b3a88de013845a304ea77d8b9b9286a0d7b/crates/web-sys/webidls/enabled/CanvasRenderingContext2D.webidl#L136 | ||
| Affine::default() |
There was a problem hiding this comment.
yea this looks good. I would also open an issue when this is merged.
|
update: just merged #112, which means there's another backend we will want to add this to. |
|
This should be ready to get merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to linebender/druid#430 and exposes
current_transform()and required for linebender/druid#466